Add reflection based support for deserializing ROS2 MCAP #11367
+2,213
−452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxkitsune
added
📺 re_viewer
|
Web viewer built successfully.
Note: This comment is updated whenever you push a commit. |
oxkitsune
force-pushed
the
gijs/ros2-parser
branch
from
02b8ef4 to
c568ddd
Compare
|
Is this the right "spec" for ROS2? (do we care about ROS1) https://docs.ros.org/en/kilted/Concepts/Basic/About-Interfaces.html#interfaces |
oxkitsune
force-pushed
the
gijs/ros2-parser
branch
from
a8ace95 to
4ef2fc6
Compare
This implements the spec for ROS2 .msg messages, which is only slightly different from the ROS1 message spec. Adding support for ROS1 in the future is trivial with this in place. This does not implement parsing of ROS2 .idl message definitions |
grtlr
reviewed
Oct 6, 2025
grtlr
approved these changes
Oct 7, 2025
oxkitsune
force-pushed
the
gijs/ros2-parser
branch
from
916e102 to
f2d4028
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds support for dynamically deserializing ROS2 MCAP messages into arrow data.
This is done by parsing the ROS2 message definition and using the type definition to deserialize the CDR-encoded data into arrow types.
TODO: